-
Notifications
You must be signed in to change notification settings - Fork 416
Some Custom Improvements. #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
2b16794
4aecc15
992df52
e32eb01
a9a7169
f63f561
ddf69e7
4d92e75
6878356
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,72 @@ | ||||||
| #ifndef TIMEZONES_GMT_H | ||||||
| #define TIMEZONES_GMT_H | ||||||
|
|
||||||
| // This file is used to set up GMT based timezones. | ||||||
|
|
||||||
| // You don't need to change anything here to be able to set up GMT based time. | ||||||
| // If you set TIMEZONES_NON_GMT_OVERRIDE to 1 (as for get summer time and leaps), | ||||||
|
||||||
| // If you set TIMEZONES_NON_GMT_OVERRIDE to 1 (as for get summer time and leaps), | |
| // If you set TIMEZONES_NON_GMT_OVERRIDE to 1 (as to get summer time and leaps), |
Copilot
AI
Dec 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment "Visit the link below" on line 11 does not actually provide a link. Either add the intended URL or remove this comment.
| // Visit the link below. |
Copilot
AI
Dec 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Trailing whitespace on line 33. Remove the spaces after the closing brace and semicolon.
| }; | |
| }; |
Copilot
AI
Dec 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OFFSETS_SEC array has incorrect signs for all timezone offsets. In POSIX notation, "Etc/GMT+N" represents a timezone N hours behind UTC (i.e., UTC-N), so it needs a negative offset. Conversely, "Etc/GMT-N" is UTC+N and needs a positive offset. Currently, all the signs are inverted. For example, index 1 is "Etc/GMT+1" (UTC-1) but has offset 3600 when it should be -3600. Index 14 is "Etc/GMT-1" (UTC+1) but has offset -3600 when it should be 3600. All non-zero offset values need their signs flipped.
| 0, 3600, 7200, 10800, 14400, 18000, 21600, 25200, 28800, 32400, 36000, 39600, 43200, 0, -3600, -7200, -10800, -14400, -18000, -21600, -25200, -28800, -32400, -36000, -39600, -43200, -46800, -50400 | |
| 0, -3600, -7200, -10800, -14400, -18000, -21600, -25200, -28800, -32400, -36000, -39600, -43200, 0, 3600, 7200, 10800, 14400, 18000, 21600, 25200, 28800, 32400, 36000, 39600, 43200, 46800, 50400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value of
darkBorderhas been changed fromfalsetotrue. This is a behavior change that will affect all existing watch faces and displays. Ensure this change is intentional and documented, as it will alter the visual appearance of the display border for all users upgrading to this version.