Add DSL for Redis Queue channel adapters.#10911
Merged
artembilan merged 4 commits intospring-projects:mainfrom Apr 7, 2026
Merged
Add DSL for Redis Queue channel adapters.#10911artembilan merged 4 commits intospring-projects:mainfrom
artembilan merged 4 commits intospring-projects:mainfrom
Conversation
Related to: spring-projects#8108 Also add respective Java DSL and Java usage in redis.adoc. Additionally, add missing MessageConverter sample for channel adapters in redis.adoc. Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
cppwfs
requested changes
Apr 6, 2026
Contributor
cppwfs
left a comment
cppwfs
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Have a couple of things for you to take a look at.
...ain/java/org/springframework/integration/redis/dsl/RedisQueueOutboundChannelAdapterSpec.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/integration/redis/dsl/RedisQueueInboundChannelAdapterSpec.java
Outdated
Show resolved
Hide resolved
...ng-integration-redis/src/test/java/org/springframework/integration/redis/dsl/RedisTests.java
Outdated
Show resolved
Hide resolved
...ng-integration-redis/src/test/java/org/springframework/integration/redis/dsl/RedisTests.java
Outdated
Show resolved
Hide resolved
artembilan
requested changes
Apr 6, 2026
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Just my five fingers for this contribution.
Thanks
spring-integration-redis/src/main/java/org/springframework/integration/redis/dsl/Redis.java
Outdated
Show resolved
Hide resolved
Refine Javadoc and update redis.adoc documentation Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
artembilan
requested changes
Apr 7, 2026
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Just couple minor code style nit-picks.
Thanks.
spring-integration-redis/src/main/java/org/springframework/integration/redis/dsl/Redis.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/integration/redis/dsl/RedisQueueInboundChannelAdapterSpec.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/integration/redis/dsl/RedisQueueOutboundChannelAdapterSpec.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/integration/redis/dsl/RedisQueueInboundChannelAdapterSpec.java
Show resolved
Hide resolved
revise the length of code lines, less than 120 symbols per line. Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #8108
Also add respective Java DSL and Java usage in redis.adoc.
Additionally, add missing MessageConverter sample for channel adapters in redis.adoc.