Open
Conversation
When a recipe declares a namespaced var option like `mylib.namespace_style/major_minor`, the value was added as a standalone VarRequest but not attached to the corresponding PkgRequestWithOptions. The solver needs the var in the package request's options map (as Complete) to satisfy a required var constraint. Collect namespaced var options in get_build_requirements() and attach them to their corresponding package requests. Also fix the checks solver's impossible request pre-check to translate request options into build options on the dummy recipe so the combining logic preserves them as Complete. Signed-off-by: J Robert Ray <jrray@imageworks.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
dcookspi
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a recipe declares a namespaced var option like
mylib.namespace_style/major_minor, the value was added as a standalone VarRequest but not attached to the corresponding PkgRequestWithOptions. The solver needs the var in the package request's options map (as Complete) to satisfy a required var constraint.Collect namespaced var options in get_build_requirements() and attach them to their corresponding package requests. Also fix the checks solver's impossible request pre-check to translate request options into build options on the dummy recipe so the combining logic preserves them as Complete.