Skip to content

Required vars and cmdline opts GitHub#1357

Open
jrray wants to merge 2 commits intomainfrom
required-vars-and-cmdline-opts-github
Open

Required vars and cmdline opts GitHub#1357
jrray wants to merge 2 commits intomainfrom
required-vars-and-cmdline-opts-github

Conversation

@jrray
Copy link
Copy Markdown
Collaborator

@jrray jrray commented Apr 22, 2026

Attach namespaced command-line options to parsed package requests
as complete request options so required vars can be satisfied by
matching builds.

Add a regression test in flags_test to verify parse_request keeps
matching options and filters unrelated options.

jrray and others added 2 commits April 22, 2026 14:00
Signed-off-by: J Robert Ray <jrray@imageworks.com>
Attach namespaced command-line options to parsed package requests
as complete request options so required vars can be satisfied by
matching builds.

Add a regression test in flags_test to verify parse_request keeps
matching options and filters unrelated options.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: J Robert Ray <jrray@imageworks.com>
@jrray jrray self-assigned this Apr 22, 2026
@jrray jrray added bug Something isn't working AI Code authored with AI assistance. labels Apr 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/spk-cli/common/src/flags_test.rs 96.42% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@jrray jrray requested a review from dcookspi April 22, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Code authored with AI assistance. bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant