Fix flaky TestExitDetection in peertracker package#6854
Open
amartinezfayo wants to merge 1 commit intospiffe:mainfrom
Open
Fix flaky TestExitDetection in peertracker package#6854amartinezfayo wants to merge 1 commit intospiffe:mainfrom
amartinezfayo wants to merge 1 commit intospiffe:mainfrom
Conversation
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
amartinezfayo
requested review from
MarcosDY,
evan2645,
rturner3 and
sorindumitru
as code owners
sorindumitru
approved these changes
Apr 10, 2026
Collaborator
sorindumitru
left a comment
sorindumitru
left a comment
There was a problem hiding this comment.
I think the grandchild process now will block on that new io.ReadAll, but I'm not sure. Either way, it's probably ok because we send it a SIGKILL at the end of the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestExitDetectioncould time out when the child process exited beforeListener.AcceptcalledNewWatcherto open/proc/<pid>. When that happened,NewWatcherfailed,Acceptdiscarded the connection and looped forever waiting for a new one that never arrived.An example of a test failure is here: https://github.com/spiffe/spire/actions/runs/24145996427/job/70460046788?pr=6847
The child binary now blocks on stdin after writing the grandchild PID, keeping it alive until the test explicitly releases it. The test calls
releaseChild()afterAcceptreturns, ensuring the watcher is created while the child is still alive.The test still validates the same behavior: exit detection works correctly when the original caller dies but a descendant holds the connection open.