feat: Allow JWT signing keys to be shared (closes #4699)#6537
Draft
keeganwitt wants to merge 1 commit intospiffe:mainfrom
Draft
feat: Allow JWT signing keys to be shared (closes #4699)#6537keeganwitt wants to merge 1 commit intospiffe:mainfrom
keeganwitt wants to merge 1 commit intospiffe:mainfrom
Conversation
61af2e1 to
705e1fb
Compare
Signed-off-by: Keegan Witt <keeganwitt@gmail.com>
705e1fb to
3df263c
Compare
Collaborator
|
We've discussing this a bit, here's a summary of the discussions so far (at least the parts I remember):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Description of change
Adds the ability to share signing keys between server instances rather than each instance managing its own key pairs, so that the number of keys that will be exposed in the JWKS endpoint is reduced.
Which issue this PR fixes
#4699