fix: versionadded (etc) directives had incorrect paragraph line numbers#14309
Open
nedbat wants to merge 2 commits intosphinx-doc:masterfrom
Open
fix: versionadded (etc) directives had incorrect paragraph line numbers#14309nedbat wants to merge 2 commits intosphinx-doc:masterfrom
nedbat wants to merge 2 commits intosphinx-doc:masterfrom
Conversation
Contributor
Author
|
This doesn't seem to be right yet. |
nedbat
force-pushed
the
nedbat/fix-versionadded
branch
from
32b8f75 to
f679901
Compare
This had been changed in https://github.com/sphinx-doc/sphinx/pull/13714/changes#diff-85deef13a7fd645931ec5da87cf4d6e016f02a7f05e503a93c7eefc5fcb2f86dR316-R320 as part of an overzealous search/replace.
nedbat
force-pushed
the
nedbat/fix-versionadded
branch
from
a458ae2 to
d372e64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In using the docutils doctree to analyze links in .rst files, I found that the paragraphs following
versionaddeddirectives had the wrong line numbers: instead of being the number of the first line of the paragraph, they has the number of the first line after the paragraph.I believe this fixes the problem.
I don't know why, but without this fix, errors in
versionaddedparagraphs have the correct line numbers, and with this fix, they still have the correct line numbers. Insights appreciated.