Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores the hyperlink for None in type annotations, which stopped working after Sphinx 4.4.0.
The previous commit (5da68c3) removed special handling for None. I added that logic back in PyField and PyTypedField classes. None should be handled as an object reference (:obj:) not as a class reference (:class:).
##Testing
I ran all Python domain tests (98 tests passed).
I created a small test document using None in type hints.
Verified that None is now clickable and properly linked again.
Note on failing CI checks
The following test failures appear to be pre existing issues unrelated to this PR:
These tests are failing on the main branch as well and are not caused by the changes in this PR.
##My changes only touch:
Nonehyperlink handlingReferences
fixes #10899