Skip to content

fixed Abstraction violation (#1169) #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markadodo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed Abstraction violation (#1169) #1331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions lib/cadet/assessments/assessments.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,22 @@ defmodule Cadet.Assessments do
result
end

def assessments_total_xp(%CourseRegistration{id: cr_id}) do
def assessments_total_xp(%CourseRegistration{id: cr_id}) when is_ecto_id(cr_id) do
Logger.info("Calculating total XP for assessments for user #{cr_id}")
teams = find_teams(cr_id)
submission_ids = get_submission_ids(cr_id, teams)

Logger.debug("Fetching submission IDs")

submission_ids =
Submission
|> join(:left, [s], t in Team, on: s.team_id == t.id)
|> join(:left, [s, t], tm in assoc(t, :team_members))
|> where(
[s, _t, tm],
s.student_id == ^cr_id or tm.student_id == ^cr_id
)
|> distinct(true)
|> select([s], s.id)


Logger.info("Fetching XP for submissions")

Expand Down
Loading