fix(ci): remove persist-credentials:false for GITHUB_TOKEN auth#98
Merged
pablofmena merged 1 commit intomasterfrom Apr 6, 2026
Merged
Conversation
With the switch from CI_TOKEN (PAT) to GITHUB_TOKEN, persist-credentials:false is no longer needed and prevents actions/checkout from setting up git auth. Without it, semantic-release fails to push with "Invalid username or token". Made-with: Cursor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Collaborator
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Follow-up to #96 (switch to
GITHUB_TOKEN). The release workflow still fails becausepersist-credentials: falseonactions/checkoutprevents the checkout action from setting up git credentials. Semantic-release then tries to authenticate git push by embedding the token in the HTTPS URL, but GitHub rejects it with:See failed run.
Implementation
Removes
persist-credentials: falsefrom the checkout step. This setting was needed when usingCI_TOKEN(a PAT fromintervene-ci) to prevent the checkout action'sGITHUB_TOKENcredentials from conflicting with the PAT. Now that we useGITHUB_TOKENfor everything, checkout can handle git auth natively via itsextraheaderconfig.How To Test
Merge and wait for the next releasable commit on
master. The release workflow should push the version tag and CHANGELOG commit without auth errors.Made with Cursor