Migrate to use clang-tidy v22

.clang-tidy

@@ -1,47 +1,72 @@
 Checks: >
-    *,-clang-analyzer-alpha.*,-hicpp-*,
+    *,
+    -clang-analyzer-*,
+    -hicpp-*,
     -clang-diagnostic-ignored-optimization-argument,
+    -clang-diagnostic-elaborated-enum-base,
     -altera-*,
     -abseil-*,
     -boost-*,
+    -bugprone-crtp-constructor-accessibility,
+    -bugprone-derived-method-shadowing-base-method,
+    -bugprone-easily-swappable-parameters,
+    -bugprone-implicit-widening-of-multiplication-result,
     -bugprone-macro-parentheses,
     -bugprone-narrowing-conversions,-cppcoreguidelines-narrowing-conversions,
+    -fuchsia-multiple-inheritance,-misc-multiple-inheritance,
     -llvmlibc-*,
     -modernize-concat-nested-namespaces,
     -modernize-loop-convert,
+    -modernize-return-braced-init-list,
+    -modernize-use-constraints,
+    -modernize-use-integer-sign-comparison,
     -modernize-use-nodiscard,
+    -modernize-use-ranges,
     -modernize-use-trailing-return-type,
     -cppcoreguidelines-avoid-const-or-ref-data-members,
     -cppcoreguidelines-avoid-do-while,
+    -cppcoreguidelines-avoid-goto, -hicpp-avoid-goto,
     -cppcoreguidelines-avoid-magic-numbers,
+    -cppcoreguidelines-init-variables,
     -cppcoreguidelines-non-private-member-variables-in-classes,
     -cppcoreguidelines-macro-usage,
     -fuchsia-overloaded-operator,-fuchsia-default-arguments*,
-    hicpp-avoid-goto,hicpp-exception-baseclass,hicpp-multiway-paths-covered,
-    hicpp-no-assembler,hicpp-signed-bitwise,
+    -cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,
     -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
     -cppcoreguidelines-pro-bounds-constant-array-index,
     -cppcoreguidelines-pro-bounds-pointer-arithmetic,
+    -cppcoreguidelines-pro-type-union-access,
+    -cppcoreguidelines-use-default-member-init,-modernize-use-default-member-init,
+    -cppcoreguidelines-use-enum-class,
     -google-readability-casting,
     -google-readability-todo,
     -google-runtime-references,
     -hicpp-signed-bitwise,
+    -llvm-else-after-return,
     -llvm-header-guard,
     -llvm-include-order,
+    -llvm-use-ranges,
     -performance-noexcept-move-constructor,
     -performance-avoid-endl,
+    -portability-avoid-pragma-once,
+    -readability-container-contains,
+    -readability-else-after-return,
     -readability-identifier-length,
     -readability-implicit-bool-conversion,
+    -readability-inconsistent-declaration-parameter-name,
+    -readability-isolate-declaration,
     -readability-named-parameter,
     -readability-magic-numbers,
+    -readability-math-missing-parentheses,
     -readability-redundant-access-specifiers,
+    -readability-redundant-inline-specifier,
+    -readability-redundant-typename,
     -misc-non-private-member-variables-in-classes,
     -misc-confusable-identifiers,
     -misc-include-cleaner,
+    -misc-unused-alias-decls,
     -misc-use-internal-linkage
 WarningsAsErrors: ''
-HeaderFilterRegex: 'modmesh.*'
-AnalyzeTemporaryDtors: false
 FormatStyle: google
 CheckOptions:
   - key: cppcoreguidelines-macro-usage.AllowedRegexp

.github/actions/setup_linux/action.yml

@@ -76,12 +76,12 @@ runs:
       if: ${{ inputs.workflow == 'lint' }}
       shell: bash
       run: |
-        # Install clang-tidy-21 from LLVM repository for full C++23 support
+        # Install clang-tidy-22 from LLVM repository for full C++23 support
         wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | sudo tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc
-        echo "deb http://apt.llvm.org/noble/ llvm-toolchain-noble-21 main" | sudo tee /etc/apt/sources.list.d/llvm.list
+        echo "deb http://apt.llvm.org/noble/ llvm-toolchain-noble-22 main" | sudo tee /etc/apt/sources.list.d/llvm.list
         sudo apt-get -qqy update
-        sudo apt-get -qy install clang-tidy-21
-        sudo ln -fs "$(which clang-tidy-21)" "/usr/local/bin/clang-tidy"
+        sudo apt-get -qy install clang-tidy-22
+        sudo ln -fs "$(which clang-tidy-22)" "/usr/local/bin/clang-tidy"
 
     - name: Install and configure gcc-14
       shell: bash

.github/actions/setup_macos/action.yml

@@ -24,17 +24,17 @@ runs:
         # This has been replaced by the 'install qt' section below to manage
         # qt6 versioning independently from the OS.
         # brew install llvm@21 qt6
-        brew install llvm@21
+        brew install llvm@22
         # The macos-26 runner ships with Homebrew llvm@20 linked into
         # /usr/local/bin/ (clang, clang++, clang-format, clang-tidy, etc.).
-        # Use -sf to overwrite the existing clang-tidy with our llvm@21
+        # Use -sf to overwrite the existing clang-tidy with our llvm@22
         # version, and remove clang/clang++ so that ccache-action
         # (create-symlink: true) can create its own symlinks.
         # clang-format is installed separately via pip (see below) so that
         # both CI platforms use the version pinned by
         # CLANG_FORMAT_CI_VERSION in the Makefile.
         # Ref: https://github.com/actions/runner-images/blob/main/images/macos/macos-26-Readme.md
-        ln -sf "$(brew --prefix llvm@21)/bin/clang-tidy" "/usr/local/bin/clang-tidy"
+        ln -sf "$(brew --prefix llvm@22)/bin/clang-tidy" "/usr/local/bin/clang-tidy"
         rm -f /usr/local/bin/clang /usr/local/bin/clang++ /usr/local/bin/clang-format
 
     - name: install qt

CMakeLists.txt

@@ -58,7 +58,15 @@ find_program(
 )
 if(USE_CLANG_TIDY)
     if(CLANG_TIDY_EXE)
-        set(DO_CLANG_TIDY "${CLANG_TIDY_EXE}" "-header-filter=/cpp/.\*/modmesh/.\*" "--extra-arg=-std=c++2b")
+        set(DO_CLANG_TIDY "${CLANG_TIDY_EXE}"
+            "-header-filter=/cpp/.\*"
+            "--extra-arg=-std=c++23"
+            # FIXME: Remove --allow-no-checks in the future after figuring out
+            # why the error message "Error: no checks enabled." appears with
+            # some files, after upgrading to clang-tidy-22.
+            # Related information (but not what we see in modmesh):
+            # https://github.com/llvm/llvm-project/issues/192713
+            "--allow-no-checks")
         if(LINT_AS_ERRORS)
             set(DO_CLANG_TIDY "${DO_CLANG_TIDY}" "-warnings-as-errors=*")
         endif()

cpp/modmesh/CMakeLists.txt

@@ -175,6 +175,7 @@ else () # MSVC
         ${COMMON_COMPILER_OPTIONS}
         -Wno-unused-value # for PYBIND11_EXPAND_SIDE_EFFECTS in pybind11.h
         -Wno-noexcept-type # GCC
+        -Wno-elaborated-enum-base # for apple accelerate/veclib
     )
 endif () # MSVC
 

cpp/modmesh/base.hpp

@@ -41,7 +41,7 @@
 #include <optional>
 #include <sstream>
 
-#if defined(_MSC_VER)
+#ifdef _MSC_VER
 #include <BaseTsd.h>
 typedef SSIZE_T ssize_t;
 #endif
@@ -156,7 +156,7 @@ class [[deprecated("Use std::format instead")]] Formatter
     // NOLINTNEXTLINE(google-explicit-constructor)
     operator std::string() const { return m_stream.str(); }
 
-    enum ConvertToString
+    enum ConvertToString : std::uint8_t
     {
         to_str
     };

cpp/modmesh/buffer/BufferBase.hpp

@@ -69,7 +69,7 @@ class BufferBase
     using size_type = std::size_t;
     using difference_type = std::ptrdiff_t;
 
-    explicit operator bool() const { return bool(m_begin); }
+    explicit operator bool() const { return static_cast<bool>(m_begin); }
     size_type size() const
     {
         return static_cast<size_type>(this->m_end - this->m_begin);
@@ -128,12 +128,14 @@ class BufferBase
     {
     }
 
+public:
     BufferBase(BufferBase const &) = delete;
     BufferBase(BufferBase &&) = delete;
     BufferBase & operator=(BufferBase const &) = delete;
     BufferBase & operator=(BufferBase &&) = delete;
     ~BufferBase() = default;
 
+protected:
     void validate_range(size_t it) const
     {
         if (it >= size())

cpp/modmesh/buffer/BufferExpander.hpp

@@ -78,7 +78,7 @@ class BufferExpander
     {
         m_begin = m_concrete_buffer->data();
         m_end = m_begin + m_concrete_buffer->size();
-        m_end_cap = m_begin + m_concrete_buffer->size();
+        m_end_cap = m_begin + m_concrete_buffer->size(); // NOLINT(cppcoreguidelines-prefer-member-initializer)
     }
 
     BufferExpander(std::shared_ptr<ConcreteBuffer> const & buf, bool clone, ctor_passkey const &)
@@ -98,9 +98,9 @@ class BufferExpander
     {
     }
 
-    BufferExpander(ctor_passkey const &)
+    explicit BufferExpander(ctor_passkey const &)
         : BufferBase<BufferExpander>(nullptr, nullptr)
-        , m_alignment(0)
+        , m_alignment(0) // NOLINT(cppcoreguidelines-use-default-member-init,modernize-use-default-member-init)
     {
     }
 
@@ -151,7 +151,7 @@ class BufferExpander
 
     std::shared_ptr<ConcreteBuffer> copy_concrete(size_type cap = 0) const;
     std::shared_ptr<ConcreteBuffer> const & as_concrete(size_type cap = 0);
-    bool is_concrete() const { return bool(m_concrete_buffer); }
+    bool is_concrete() const { return static_cast<bool>(m_concrete_buffer); }
 
     size_type alignment() const noexcept { return m_alignment; }
 
@@ -178,7 +178,7 @@ class BufferExpander
                 std::free(ptr);
             }
 #else
-            std::free(ptr);
+            std::free(ptr); // NOLINT(cppcoreguidelines-owning-memory,cppcoreguidelines-no-malloc)
 #endif
         }
     };
@@ -197,13 +197,13 @@ class BufferExpander
 #ifdef _WIN32
                 ptr = _aligned_malloc(nbytes, alignment);
 #else
-                ptr = std::aligned_alloc(alignment, nbytes);
+                ptr = std::aligned_alloc(alignment, nbytes); // NOLINT(cppcoreguidelines-owning-memory,cppcoreguidelines-no-malloc)
 #endif
             }
             else
             {
                 // Use malloc instead of new[] so we can consistently use free in the deleter
-                ptr = std::malloc(nbytes);
+                ptr = std::malloc(nbytes); // NOLINT(cppcoreguidelines-owning-memory,cppcoreguidelines-no-malloc)
             }
             if (!ptr)
             {

cpp/modmesh/buffer/ConcreteBuffer.hpp

@@ -63,17 +63,17 @@ struct ConcreteBufferRemover
 
     static void deallocate_memory(int8_t * p, size_t alignment)
     {
-        if (alignment > 0)
+        if (alignment > 0) // NOLINT(bugprone-branch-clone)
         {
 #ifdef _WIN32
-            _aligned_free(p);
+            _aligned_free(p); // NOLINT(cppcoreguidelines-owning-memory,cppcoreguidelines-no-malloc)
 #else
-            std::free(p);
+            std::free(p); // NOLINT(cppcoreguidelines-owning-memory,cppcoreguidelines-no-malloc)
 #endif
         }
         else
         {
-            std::free(p);
+            std::free(p); // NOLINT(cppcoreguidelines-owning-memory,cppcoreguidelines-no-malloc)
         }
     }
 
@@ -264,7 +264,7 @@ class ConcreteBuffer
         return *this;
     }
 
-    bool has_remover() const noexcept { return bool(m_data.get_deleter().remover); }
+    bool has_remover() const noexcept { return static_cast<bool>(m_data.get_deleter().remover); }
     remover_type const & get_remover() const { return *m_data.get_deleter().remover; }
     remover_type & get_remover() { return *m_data.get_deleter().remover; }
 
@@ -286,14 +286,14 @@ class ConcreteBuffer
             {
                 validate_size_alignment(nbytes, alignment, "ConcreteBuffer::allocate");
 #ifdef _WIN32
-                ptr = _aligned_malloc(nbytes, alignment);
+                ptr = _aligned_malloc(nbytes, alignment); // NOLINT(cppcoreguidelines-owning-memory,cppcoreguidelines-no-malloc)
 #else
-                ptr = std::aligned_alloc(alignment, nbytes);
+                ptr = std::aligned_alloc(alignment, nbytes); // NOLINT(cppcoreguidelines-owning-memory,cppcoreguidelines-no-malloc)
 #endif
             }
             else
             {
-                ptr = std::malloc(nbytes);
+                ptr = std::malloc(nbytes); // NOLINT(cppcoreguidelines-owning-memory,cppcoreguidelines-no-malloc)
             }
             if (!ptr)
             {

cpp/modmesh/buffer/SimpleArray.cpp

@@ -54,7 +54,7 @@ struct DataTypeHasher
     }
 }; /* end struct DataTypeHasher */
 
-// NOLINTNEXTLINE(misc-use-anonymous-namespace, cert-err58-cpp, cppcoreguidelines-avoid-non-const-global-variables, fuchsia-statically-constructed-objects)
+// NOLINTNEXTLINE(misc-use-anonymous-namespace, cert-err58-cpp, bugprone-throwing-static-initialization, cppcoreguidelines-avoid-non-const-global-variables, fuchsia-statically-constructed-objects)
 static std::unordered_map<std::string, DataType, DataTypeHasher> string_data_type_map = {
     {"bool", DataType::Bool},
     {"int8", DataType::Int8},