Skip to content

updated to use login package#59

Open
PreciousOritsedere wants to merge 1 commit intomainfrom
integrating-login-package
Open

updated to use login package#59
PreciousOritsedere wants to merge 1 commit intomainfrom
integrating-login-package

Conversation

@PreciousOritsedere
Copy link
Copy Markdown
Contributor

@PreciousOritsedere PreciousOritsedere commented Mar 6, 2026

No description provided.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 6, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-file-manager Ready Ready Preview, Comment Mar 6, 2026 6:04pm

langsamu
langsamu reviewed Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@langsamu langsamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with any of this tech.

I'm happy to review nonetheless but then please describe change, expected outcome etc.

@PreciousOritsedere
Copy link
Copy Markdown
Contributor Author

PreciousOritsedere commented Mar 25, 2026

I'm not familiar with any of this tech.

I'm happy to review nonetheless but then please describe change, expected outcome etc.

I'm not familiar with any of this tech.

I'm happy to review nonetheless but then please describe change, expected outcome etc.

I created a package: https://www.npmjs.com/package/solid-react-component that allows us simply import a solid react component , in this case the solid login component. So this PR is basically using this package to replace the login page in the solid file manager.

Please help me review, so it can be merged in.

langsamu
langsamu approved these changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@langsamu langsamu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamping without review to unblock progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@langsamu langsamu langsamu approved these changes

@jeswr jeswr Awaiting requested review from jeswr jeswr is a code owner

@hkir-dev hkir-dev Awaiting requested review from hkir-dev hkir-dev is a code owner

@matthieubosquet matthieubosquet Awaiting requested review from matthieubosquet matthieubosquet is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PreciousOritsedere @langsamu