Skip to content

Use SolanaError instance as CU simulation failure cause #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lorisleiva merged 1 commit into from
Jan 23, 2026
Merged

Use SolanaError instance as CU simulation failure cause #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clients/js/src/estimateComputeLimitInternal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
Commitment,
compileTransaction,
getBase64EncodedWireTransaction,
getSolanaErrorFromTransactionError,
isSolanaError,
isTransactionMessageWithDurableNonceLifetime,
pipe,
Expand Down Expand Up @@ -158,7 +159,7 @@ async function simulateTransactionAndGetConsumedUnits({
const downcastUnitsConsumed = unitsConsumed > 4_294_967_295n ? 4_294_967_295 : Number(unitsConsumed);
if (transactionError) {
throw new SolanaError(SOLANA_ERROR__TRANSACTION__FAILED_WHEN_SIMULATING_TO_ESTIMATE_COMPUTE_LIMIT, {
cause: transactionError,
cause: getSolanaErrorFromTransactionError(transactionError),
unitsConsumed: downcastUnitsConsumed,
});
}
Expand Down
5 changes: 3 additions & 2 deletions clients/js/test/estimateComputeLimitInternal.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
SOLANA_ERROR__INSTRUCTION_ERROR__INSUFFICIENT_FUNDS,
SOLANA_ERROR__TRANSACTION__FAILED_TO_ESTIMATE_COMPUTE_LIMIT,
SOLANA_ERROR__TRANSACTION__FAILED_WHEN_SIMULATING_TO_ESTIMATE_COMPUTE_LIMIT,
SOLANA_ERROR__TRANSACTION_ERROR__ACCOUNT_NOT_FOUND,
SolanaError,
TransactionError,
TransactionMessageWithFeePayer,
Expand Down Expand Up @@ -235,7 +236,7 @@ describe('estimateComputeUnitLimit', () => {
await expect(estimatePromise).resolves.toBe(1400000);
});

it('throws with the transaction error as cause when the transaction fails in simulation', async () => {
it('throws with the transaction SolanaError as cause when the transaction fails in simulation', async () => {
expect.assertions(1);
const transactionError: TransactionError = 'AccountNotFound';
sendSimulateTransactionRequest.mockResolvedValue({
Expand All @@ -249,7 +250,7 @@ describe('estimateComputeUnitLimit', () => {

await expect(estimatePromise).rejects.toThrow(
new SolanaError(SOLANA_ERROR__TRANSACTION__FAILED_WHEN_SIMULATING_TO_ESTIMATE_COMPUTE_LIMIT, {
cause: transactionError,
cause: new SolanaError(SOLANA_ERROR__TRANSACTION_ERROR__ACCOUNT_NOT_FOUND),
unitsConsumed: 42,
}),
);
Expand Down