fix: evaluate Go plugin feature flags early#6645
Merged
mcombuechen merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
ecaa806 to
df1215b
Compare
df1215b to
ed8d718
Compare
ed8d718 to
e2c9b44
Compare
84eb482 to
89b2278
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
CatalinSnyk
approved these changes
Mar 17, 2026
89b2278 to
13ad299
Compare
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Max <max.combuchen@snyk.io>
13ad299 to
f2f5ba2
Compare
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Evaluates the
includeGoStandardLibraryDepsanddisableGoPackageUrlsInClifeature flags at the command entry points (test, monitor) instead of evaluating at the individual plugin level. This aligns with the existing pattern used by other feature flags (e.g.hasPnpmSupport) where they resolve once at the command entry point. In the current stable release, this causes exceedingly large amounts of traffic to FF endpoints and added latency for use cases with many Go projects (--all-projects).