chore: replace chocolatey with native binaries#6639
Conversation
This comment has been minimized.
This comment has been minimized.
821cecc to
bdef5ed
Compare
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
cdd8b29 to
69056fa
Compare
|
/review |
This comment has been minimized.
This comment has been minimized.
|
/review |
This comment has been minimized.
This comment has been minimized.
110e69f to
765b462
Compare
|
/review |
This comment has been minimized.
This comment has been minimized.
765b462 to
42b39b5
Compare
|
/review |
This comment has been minimized.
This comment has been minimized.
42b39b5 to
aa336dc
Compare
|
/review |
This comment has been minimized.
This comment has been minimized.
aa336dc to
9d7b8ac
Compare
|
/review |
This comment has been minimized.
This comment has been minimized.
48e9b8d to
87bc5f9
Compare
87bc5f9 to
e3ce3eb
Compare
|
/review |
This comment has been minimized.
This comment has been minimized.
e3ce3eb to
267dab2
Compare
|
/review |
This comment has been minimized.
This comment has been minimized.
267dab2 to
f606343
Compare
PR Reviewer Guide 🔍
|
| CC: << parameters.c_compiler >> | ||
| MACOSX_DEPLOYMENT_TARGET: 13.0 | ||
| command: make << parameters.make_target >> GOOS=<< parameters.go_target_os >> GOARCH=<< parameters.go_arch >> STATIC_NODE_BINARY=true CGO_ENABLED=0 | ||
| # Windows static build (use PowerShell and ensure GNU make is on PATH) |
There was a problem hiding this comment.
Question: This block adds quite some duplication which is difficult to maintain just to load environment variables, is there a way to avoid this?
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
In CircleCI, run the full Windows pipeline on a test branch:
windows amd64andsign windows amd64pass and produce expected artifacts.windows amd64pass, including SBOM tests that rely on Maven and Python.What's the product update that needs to be communicated to CLI users?
There is no functional CLI behavior change for end users; this PR only changes how Windows CI builds and tests the CLI.