You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once isStderrTruncated is set to true (after stderr exceeds 50MB), the code stops accumulating any further chunks into the stderr variable returned in GoCommandResult. If the Go process produces a large volume of debug logs followed by a terminal error message, that error message will be present in the streamed output (if --debug is active) but missing from the stderr property of the result object. This could lead to poor error reporting by callers who rely on the result object to extract specific error details from the Go bridge. While 50MB is a generous limit, a strategy that preserves the tail of the output (e.g., keeping the last few KB after truncation) would be more robust for error diagnostics.
if(isStderrTruncated){return;}
📚 Repository Context Analyzed
This review considered 6 relevant code sections from 6 files (average relevance: 1.02)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Stream debug logs from the internal go command to the calling typescript when the debug flag is passed.