fix: check for is error catalog error [CSENG-169]#6629
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
j-luong
reviewed
Mar 10, 2026
j-luong
reviewed
Mar 10, 2026
fix: correct error handling
a5c6477 to
2767f2b
Compare
This comment has been minimized.
This comment has been minimized.
j-luong
previously approved these changes
Mar 10, 2026
Contributor
|
suggest: is there any acceptance testing we can add to test when |
j-luong
approved these changes
Mar 10, 2026
This comment has been minimized.
This comment has been minimized.
danskmt
reviewed
Mar 11, 2026
danskmt
reviewed
Mar 11, 2026
This comment has been minimized.
This comment has been minimized.
danskmt
approved these changes
Mar 11, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Adds a further check for catalog errors returned from plugin
Updates error catalog version with new python errors
Updates the snyk-python-plugin version with updates error handling
See json error object in error-catalog-nodejs-public/src/problem-error.ts, isErrorCatalogError = true
Where should the reviewer start?
Review error check change
How should this be manually tested?
snky cli & sbom tests to verify correct error codes being returned to the user
Test the following scenarios with python repo
What's the product update that needs to be communicated to CLI users?
N/A
Risk assessment (Low | Medium | High)?
Low risk
Any background context you want to provide?
Customers have reported several scenarios where they receive the generic error code SNYK-0000. Our goal is to return more meaningful information to help customers better understand the issue and troubleshoot more effectively.
This change is being implemented alongside improvements in the Python plugin, which will also return more informative error codes.
What are the relevant tickets?
https://snyksec.atlassian.net/browse/CSENG-169