Skip to content

OEV-851 Send dualBroadcast params in TxMessage#378

Open
cll-gg wants to merge 4 commits intodevelopfrom
OEV-851-send-mevshare-params-to-beholder
Open

OEV-851 Send dualBroadcast params in TxMessage#378
cll-gg wants to merge 4 commits intodevelopfrom
OEV-851-send-mevshare-params-to-beholder

Conversation

@cll-gg
Copy link
Copy Markdown
Contributor

@cll-gg cll-gg commented Mar 3, 2026

Requires

smartcontractkit/chainlink-protos#302

What

See title

Why

To store these params for analysis.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2026

📊 API Diff Results

No modules to analyze

View full report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

This PR is stale because it has been open 30 days with no activity.
Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Apr 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This PR has been automatically closed because it has been stale for > 30 days.
If you wish to continue working on this PR, please reopen it and make any necessary changes.

@github-actions github-actions Bot closed this Apr 10, 2026
@github-actions github-actions Bot deleted the OEV-851-send-mevshare-params-to-beholder branch April 10, 2026 01:00
@cll-gg cll-gg restored the OEV-851-send-mevshare-params-to-beholder branch April 22, 2026 09:18
@cll-gg cll-gg reopened this Apr 22, 2026
@cll-gg cll-gg force-pushed the OEV-851-send-mevshare-params-to-beholder branch from 57275e6 to f7794ae Compare April 22, 2026 12:00
@cll-gg cll-gg removed the Stale label Apr 22, 2026
@cll-gg cll-gg force-pushed the OEV-851-send-mevshare-params-to-beholder branch from f7794ae to 6ef5bf5 Compare April 27, 2026 16:53
@github-actions
Copy link
Copy Markdown
Contributor

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-evm

View full report

@cll-gg cll-gg marked this pull request as ready for review April 27, 2026 17:17
Copilot AI review requested due to automatic review settings April 27, 2026 17:17
@cll-gg cll-gg requested review from a team and dimriou as code owners April 27, 2026 17:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the TXM Beholder svr.v1.TxMessage emission to include dual-broadcast URL params (when the transaction is marked as dual-broadcast), enabling downstream analysis of those params.

Changes:

  • Populate DualBroadcastParams on emitted svr.v1.TxMessage when TxMeta.DualBroadcast == true.
  • Add unit tests asserting DualBroadcastParams is set/unset appropriately.
  • Bump github.com/smartcontractkit/chainlink-protos/svr dependency to v1.2.0.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
pkg/txm/metrics.go Adds conditional wiring of DualBroadcastParams into emitted TxMessage.
pkg/txm/metrics_test.go Adds coverage for presence/absence of DualBroadcastParams based on tx meta.
go.mod Updates chainlink-protos/svr to a version that includes the new TxMessage field.
go.sum Updates checksums for the chainlink-protos/svr version bump.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants