Open
Conversation
|
Code coverage report:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates duplicated “deployment/config” types (notably monitoring and generated offchain config types) into canonical packages, and updates deployment tooling and devenv to use those shared definitions.
Changes:
- Introduces
pkg/monitoringas the canonical home for monitoring config + validation, and replaces per-service copies with type aliases. - Removes deployment-local generated config structs (aggregator/indexer/token verifier) and updates env metadata + changesets to store/use the canonical types directly.
- Updates devenv + CCIP interfaces to use
deployment.EnvironmentTopologydirectly (keeping a compatibility shim for CCIP offchain topology conversion).
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| verifier/pkg/vtypes/config.go | Replaces local monitoring structs with aliases to pkg/monitoring. |
| pkg/monitoring/config.go | Adds canonical monitoring config structs + validation. |
| indexer/pkg/config/monitoring.go | Aliases indexer monitoring config to pkg/monitoring. |
| indexer/pkg/config/config.go | Adds JSON tags to generated indexer config structs. |
| executor/config.go | Aliases executor monitoring config to pkg/monitoring. |
| deployment/topology.go | Aliases deployment monitoring config to pkg/monitoring. |
| deployment/env_metadata_util.go | Stores aggregator/indexer/token-verifier offchain configs using canonical package types. |
| deployment/changesets/* | Updates changesets to build/persist canonical types (removes conversion helpers). |
| deployment/{aggregator.go,indexer.go,token_verifier.go} | Removes deployment-local type definitions (now sourced from canonical packages). |
| build/devenv/** | Removes offchainloader indirection; switches devenv topology plumbing to deployment.EnvironmentTopology. |
| aggregator/pkg/model/config.go | Adds JSON tags and aliases aggregator monitoring config to pkg/monitoring. |
| build/devenv/offchainloader/loader.go | Removed (no longer needed after using canonical types directly). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.