Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Coverage Report |
finleydecker
requested review from
a team,
PabloMansanet and
aelmanaa
as code owners
PabloMansanet
requested changes
Mar 19, 2026
Comment on lines
+321
to
+328
| const feeTokenArg = (argv.feeToken ?? '').toLowerCase() | ||
| if (feeTokenArg === 'native' || feeTokenArg === 'hbar') { | ||
| // CCIP Directory lists native HBAR as a fee token on Hedera; use ZeroAddress so EVM sends msg.value | ||
| feeToken = ZeroAddress | ||
| const wrappedNative = await source.getNativeTokenForRouter(argv.router) | ||
| feeTokenInfo = await source.getTokenInfo(wrappedNative) | ||
| feeTokenInfo = { ...feeTokenInfo, symbol: feeTokenInfo.symbol.replace(/^W/, '') || 'HBAR' } | ||
| } else if (argv.feeToken) { |
Collaborator
There was a problem hiding this comment.
This doesn't seem like the right abstraction level to do. this. Can this logic be moved down to the implementations of getTokenInfo? I don't know much about Hedera but it seems like we're bleeding pretty chain and token-specific behaviour into a file that's chain-agnostic.
Comment on lines
+388
to
+392
| feeToken === ZeroAddress | ||
| ? feeTokenInfo.symbol | ||
| : feeTokenInfo.symbol.startsWith('W') | ||
| ? feeTokenInfo.symbol.substring(1) | ||
| : feeTokenInfo.symbol |
Collaborator
There was a problem hiding this comment.
NIT: These chains of ternaries get pretty difficult to read, I think at this point good old if-elses would read easier.
Comment on lines
+1
to
+3
| export default [ | ||
| // FeeQuoter 2.0.0 ABI | ||
| { |
Collaborator
There was a problem hiding this comment.
If you look at the other ABI files in this folder, we follow a pattern where we generate them dynamically using a generate block that fetches directly from the chainlink-ccip repo. Please implement that pattern on this one too.
| Token: new Interface(Token_ABI), | ||
| TokenAdminRegistry: new Interface(TokenAdminRegistry_ABI), | ||
| FeeQuoter: new Interface(FeeQuoter_ABI), | ||
| FeeQuoter: new Interface(FeeQuoter_1_6_ABI), |
Collaborator
There was a problem hiding this comment.
Let's get rid of this one and keep only the versioned consts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.