Conversation
There was a problem hiding this comment.
Pull Request Overview
Updates Gradle wrapper scripts and build configuration for cleaner DSL usage and an upgraded Gradle version
- Refactor Kotlin build script to use type-safe task registration and expression-bodied functions
- Add SPDX headers, improve error‐level handling, and switch to
-jarexecution in Unix/BAT wrappers - Bump Gradle wrapper distribution to 8.14.1
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| jarhc/build.gradle.kts | Converted tasks.register(..., type = ...) to tasks.register<>() and refactored getGitBranchTarget |
| gradlew.bat | Added SPDX tag, changed %ERRORLEVEL% checks, switched to -jar, adjusted exit logic |
| gradlew | Added SPDX tag, updated template URL, refined APP_HOME logic, changed CLASSPATH, added xargs check |
| gradle/wrapper/gradle-wrapper.properties | Updated distributionUrl to Gradle 8.14.1 |
Comments suppressed due to low confidence (2)
jarhc/build.gradle.kts:480
- [nitpick] The long
if-elsechain for branch name mapping could be simplified into awhenexpression for better readability and extensibility.
fun getGitBranchTarget(branchName: String): String {
gradlew:210
- The comment refers to
optsEnvironmentVarbut that variable isn’t defined—consider updating the documentation to reference the actual environment variables (e.g.,JAVA_OPTS,GRADLE_OPTS).
* For example: A user cannot expect ${Hostname} to be expanded, as it is an environment variable and will be
| esac | ||
|
|
||
| CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar | ||
| CLASSPATH="\\\"\\\"" |
There was a problem hiding this comment.
Setting CLASSPATH to a literal "\"\"" may lead to an invalid classpath. It should likely be set to an empty string (e.g., CLASSPATH="").
Suggested change
| CLASSPATH="\\\"\\\"" | |
| CLASSPATH="" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.