Skip to content

feature/update-gradle#344

Closed
smarkwal wants to merge 1 commit intodevelopfrom
feature/update-gradle
Closed

feature/update-gradle#344
smarkwal wants to merge 1 commit intodevelopfrom
feature/update-gradle

Conversation

@smarkwal
Copy link
Copy Markdown
Owner

@smarkwal smarkwal commented Jun 4, 2025

No description provided.

@smarkwal smarkwal changed the base branch from master to develop June 4, 2025 18:30
@smarkwal smarkwal requested a review from Copilot June 4, 2025 18:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates Gradle wrapper scripts and build configuration for cleaner DSL usage and an upgraded Gradle version

  • Refactor Kotlin build script to use type-safe task registration and expression-bodied functions
  • Add SPDX headers, improve error‐level handling, and switch to -jar execution in Unix/BAT wrappers
  • Bump Gradle wrapper distribution to 8.14.1

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File Description
jarhc/build.gradle.kts Converted tasks.register(..., type = ...) to tasks.register<>() and refactored getGitBranchTarget
gradlew.bat Added SPDX tag, changed %ERRORLEVEL% checks, switched to -jar, adjusted exit logic
gradlew Added SPDX tag, updated template URL, refined APP_HOME logic, changed CLASSPATH, added xargs check
gradle/wrapper/gradle-wrapper.properties Updated distributionUrl to Gradle 8.14.1
Comments suppressed due to low confidence (2)

jarhc/build.gradle.kts:480

  • [nitpick] The long if-else chain for branch name mapping could be simplified into a when expression for better readability and extensibility.
fun getGitBranchTarget(branchName: String): String {

gradlew:210

  • The comment refers to optsEnvironmentVar but that variable isn’t defined—consider updating the documentation to reference the actual environment variables (e.g., JAVA_OPTS, GRADLE_OPTS).
* For example: A user cannot expect ${Hostname} to be expanded, as it is an environment variable and will be

Comment thread gradlew
esac

CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar
CLASSPATH="\\\"\\\""
Copy link

Copilot AI Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting CLASSPATH to a literal "\"\"" may lead to an invalid classpath. It should likely be set to an empty string (e.g., CLASSPATH="").

Suggested change
CLASSPATH="\\\"\\\""
CLASSPATH=""

Copilot uses AI. Check for mistakes.
@smarkwal smarkwal closed this Jun 4, 2025
@smarkwal smarkwal deleted the feature/update-gradle branch June 4, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants