Skip to content

No longer check if postgresql existingSecret has a custom hostname set #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xf1e wants to merge 4 commits into
base: main
Choose a base branch
from
Open

No longer check if postgresql existingSecret has a custom hostname set #660

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c770d56
`chore: Modify DATABASE_HOSTNAME logic to consider generateHostname f…
Feb 11, 2025
77fc8b0
fix: remove check for secret hostname in initContainer
Feb 11, 2025
8289bd2
chore: Bump version to 18.4.1
Feb 11, 2025
2b94cf0
Merge branch 'main' into remove-secret-psql-hostname
jessebot Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
.idea/
.DS_Store
.aider*
Copy link
Copy Markdown
Collaborator

@jessebot jessebot Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.aider*
.aider*

🤔 what's this?

2 changes: 1 addition & 1 deletion charts/matrix/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ sources:

type: application

version: 18.4.0
version: 18.4.1

# renovate: image=ghcr.io/element-hq/synapse
appVersion: v1.122.0
Expand Down
7 changes: 0 additions & 7 deletions charts/matrix/templates/synapse/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,7 @@ spec:
name: {{ include "matrix.postgresql.secretName" . }}
key: {{ .Values.postgresql.global.postgresql.auth.secretKeys.databaseUsername }}
- name: DATABASE_HOSTNAME
{{- if not .Values.postgresql.global.postgresql.auth.existingSecret }}
value: {{ template "postgresql.v1.primary.fullname" .Subcharts.postgresql }}
{{ else }}
valueFrom:
secretKeyRef:
name: {{ include "matrix.postgresql.secretName" . }}
key: {{ .Values.postgresql.global.postgresql.auth.secretKeys.databaseHostname }}
{{- end }}
Comment on lines 66 to -74
Copy link
Copy Markdown
Collaborator

@jessebot jessebot Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this break people using an external database though?

{{- if .Values.postgresql.sslmode }}
- name: PGSSLMODE
value: {{ .Values.postgresql.sslmode }}
Expand Down