Open
Conversation
…acking - Replaced synchronous `parseCSVToPVs` with async `parseCSVToPVsAsync` for better performance with large files - Added progress tracking with `ParseProgress` type to show parsing and validation status - Implemented chunked validation processing (50 rows per chunk) to prevent main thread blocking - Added progress indicators for both parsing and validation phases - Updated CSVImportDialog to handle async operations with proper state management - Enhanced error handling and user feedback during import process
…king Removed the async progress callback and chunked processing from `validateCSVTags` function. The validation now runs synchronously without progress updates, simplifying the implementation while maintaining the same validation logic and results. Updated function signature and removed progress-related code from both the validation function and its caller in CSVImportDialog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #39
This adds async processing and a spinner to indicate that the process is ongoing, and encapsulates the tag validation out of the dialog into its own function. The performance was tested to be about the same when importing consolidated.csv (20-something seconds), but at least the spinner gives the user some indication that something is happening.
Through very basic performance checking, it seems like the tag validation is the bottleneck. I tested simple chunking (similar to the chunking done for parsing), but this made performance worse.
Also removes deprecated lines in the husky pre-commit. Not sure why that change wasn't included in #71
Motivation
The bulk import PVs process wasn't providing feedback to the user when processing. For very large files (consolidated.csv in the tens of thousands of rows), this meant the application would appear to hang.
Screenshots
Pre-merge checklist