Add SkipFuse as explicit dependency for native app modules#229
Add SkipFuse as explicit dependency for native app modules#229bookii wants to merge 1 commit intoskiptools:mainfrom
Conversation
When using Skip Fuse mode, the generated Package.swift now includes skip-fuse as an explicit dependency alongside skip-fuse-ui, fixing `import SkipFuse` failures caused by Xcode 26.4 Explicitly Built Modules. Fixes skiptools/skip#662 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @bookii on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file |
|
Sorry, I mistakenly thought I had already signed the CLA. |
|
Well that's annoying, and the first I've heard about this. Can you provide some information on the context in which you encountered this limitation? The skipapp-howdy Can you clarify under what circumstances this would break? |
|
Note that we do declare an explicit dependency when a multi-module project like |
|
I just performed a clean install on this machine three days ago. Also, here is the output from % skip doctor
Skip Doctor
[✓] Skip version 1.8.6 (= 1.8.6)
[✓] macOS version 26.4.1 (> 13.5.0)
[✓] macOS architecture: ARM
[✓] Swift version 6.3 (> 5.9.0)
[✓] Swiftly version 1.1.1 (> 1.0.0)
[✓] Xcode version 26.4 (> 15.0.0)
[✓] Xcode tools SDKs: 5
[✓] Homebrew version 5.1.5 (> 4.1.0)
[✓] Gradle version 9.4.1 (> 8.6.0)
[✓] Java version 25.0.2 (> 17.0.0)
[✓] Android Debug Bridge version 1.0.41 (> 1.0.40)
[✓] Android SDK version 37.0.0 (> 29.0.0)
[✓] Check Skip Updates: 1.8.6
[✓] Skip 1.8.6 doctor succeeded in 1.38sI should also mention that running |
Starting from Xcode 26, Swift Explicit Modules is enabled by default, requiring all imported modules to be declared as explicit dependencies.
(ref: https://developer.apple.com/documentation/xcode-release-notes/xcode-26-release-notes#Resolved-Issues)
The generated Package.swift for Skip Fuse mode now includes skip-fuse alongside skip-fuse-ui, fixing
import SkipFusefailures.Fixes skiptools/skip#662
Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Skip Pull Request Checklist:
swift testI used the issue I opened (skiptools/skip#662) to have Claude Code generate the fix, and verified it by running swift test.
However, it is difficult to perform a practical verification using skip create until this fix is merged into the main skip repository.