Skip to content

Use the jsc-android-intl version of JavaScriptCore on Android #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcprux merged 1 commit into from
Apr 26, 2026
Merged

Use the jsc-android-intl version of JavaScriptCore on Android #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/SkipScript/Skip/skip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ build:
- block: 'dependencies'
contents:
# JSC is now on Maven central (https://github.com/facebook/react-native/pull/47972): https://repo1.maven.org/maven2/io/github/react-native-community/jsc-android/2026004.0.1/
- 'implementation("io.github.react-native-community:jsc-android:2026004.0.1")' # 26.9 MB
#- 'implementation("io.github.react-native-community:jsc-android-intl:2026004.0.1")' # international version: 53.7 MB
#- 'implementation("io.github.react-native-community:jsc-android:2026004.0.1")' # 26.9 MB
- 'implementation("io.github.react-native-community:jsc-android-intl:2026004.0.1")' # international version: 53.7 MB
- 'implementation("com.facebook.fbjni:fbjni:0.7.0")' # needed for libc++_shared.so, else no symbol "_ZNSt6__ndk122__libcpp_verbose_abortEPKcz"

#- 'implementation("org.webkit:android-jsc-cppruntime:r245459@aar")'
Expand Down
4 changes: 0 additions & 4 deletions Tests/SkipScriptTests/JSContextTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,6 @@ class JSContextTests : XCTestCase {
}

func testIntl() throws {
// the Skip side uses jsc-android rather than jsc-android-intl for size savings
// TODO: provide a separate SkipScriptIntl target that depends on jsc-android-intl
#if !SKIP
let ctx = try XCTUnwrap(JSContext())

XCTAssertEqual("12,34 €", ctx.evaluateScript("new Intl.NumberFormat('de-DE', { style: 'currency', currency: 'EUR' }).format(12.34)")?.toString())
Expand All @@ -104,7 +101,6 @@ class JSContextTests : XCTestCase {

XCTAssertEqual("10/24/2022", ctx.evaluateScript("new Intl.DateTimeFormat('en-US', {timeZone: 'UTC'}).format(new Date('2022-10-24'))")?.toString())
XCTAssertEqual("24/10/2022", ctx.evaluateScript("new Intl.DateTimeFormat('fr-FR', {timeZone: 'UTC'}).format(new Date('2022-10-24'))")?.toString())
#endif
}

func testProxy() throws {
Expand Down