Split string by string#43
Merged
marcprux merged 1 commit intoskiptools:mainfrom Apr 18, 2026
Merged
Conversation
marcprux
added a commit
to skiptools/skip-ui
that referenced
this pull request
Apr 19, 2026
marcprux
added a commit
to skiptools/skip-fuse-ui
that referenced
this pull request
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR may be a bit surprising, because it removes
func split(separator: Character)and adds infunc split(separator: String). To my surprise, even when I left both overloads in, the existing character-based tests were all just using the string version once I added it.Since the character-based implementation was, as far as I could tell, dead code, I eliminated it.
The implementation tries to use Kotlin
split()if we're notomittingEmptySequences, butomittingEmptySequencesdefaults to true, so a simple"a,b,c".split(separator: ",")will not use Kotlinsplit().(I also had to implement a whole separate code path for when the separator is empty, to match Swift's behavior in that case.)
Skip Pull Request Checklist:
swift testCursor generated a first draft (especially the tests), and I rewrote its output.