Skip to content

fix(agent): dismiss tool feedback when outbound is skipped#2823

Open
bogdanovich wants to merge 2 commits intosipeed:mainfrom
bogdanovich:fix/parent-session-tool-feedback-cleanup
Open

fix(agent): dismiss tool feedback when outbound is skipped#2823
bogdanovich wants to merge 2 commits intosipeed:mainfrom
bogdanovich:fix/parent-session-tool-feedback-cleanup

Conversation

@bogdanovich
Copy link
Copy Markdown

Summary

  • dismiss tracked tool feedback when the final outbound is skipped because the tool already replied to the same chat
  • add a regression test covering in that path

Testing

  • go test ./pkg/agent -run 'TestPublishResponseIfNeeded_DismissesToolFeedbackWhenMessageToolAlreadySent|TestProcessMessage_PublishesToolFeedbackWhenEnabled|TestNewAgentLoop' -count=1

@bogdanovich
Copy link
Copy Markdown
Author

Follow-up summary:

  • dismiss tracked tool feedback when the final outbound is skipped because the message tool already replied to the same chat
  • add a regression test covering PublishResponseIfNeeded in that path

Tested with:

  • go test ./pkg/agent -run 'TestPublishResponseIfNeeded_DismissesToolFeedbackWhenMessageToolAlreadySent|TestProcessMessage_PublishesToolFeedbackWhenEnabled|TestNewAgentLoop' -count=1

@bogdanovich bogdanovich force-pushed the fix/parent-session-tool-feedback-cleanup branch from fca7d22 to 610e9e3 Compare May 8, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant