fix(tools): allow relative script paths in exec guard#2814
Open
bogdanovich wants to merge 2 commits intosipeed:mainfrom
Open
fix(tools): allow relative script paths in exec guard#2814bogdanovich wants to merge 2 commits intosipeed:mainfrom
bogdanovich wants to merge 2 commits intosipeed:mainfrom
Conversation
Contributor
Author
|
Fixed the workflow failures. |
This was referenced May 8, 2026
de1454b to
d981a2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execsandbox path scanning from misclassifying relative script paths likescripts/send_voice_reply_telegram.shas absolute escaped pathsProblem
For restricted workspaces,
execcurrently scans command strings for absolute paths using a regex that matches any/...segment. That also catches the slash substring inside a relative command token such as:scripts/send_voice_reply_telegram.shThe guard then treats the matched fragment as if it were an absolute path (
/send_voice_reply_telegram.sh) and rejects the command with:Command blocked by safety guard (path outside working dir)That is a false positive. The command is workspace-local and should be allowed.
This surfaced in a Telegram voice-reply workflow, but the bug is not Telegram-specific. Any workflow that executes a relative script path containing
/from a restricted workspace can hit the same guard failure.Fix
pkg/tools/shell.go, skip regex matches that are only slash-fragments inside a larger relative token instead of standalone absolute pathsTestShellTool_RelativeScriptPathNotMisclassifiedAsAbsoluteto cover the regressionWhy this should be upstream
This is a core
execsandbox correctness fix:Validation
go test ./pkg/tools -run 'TestShellTool_(RelativeScriptPathNotMisclassifiedAsAbsolute|URLBypassPrevented|FileURISandboxing)'