fix(agents): route spawn tool to target agent#2790
Open
bogdanovich wants to merge 1 commit intosipeed:mainfrom
Open
fix(agents): route spawn tool to target agent#2790bogdanovich wants to merge 1 commit intosipeed:mainfrom
bogdanovich wants to merge 1 commit intosipeed:mainfrom
Conversation
Collaborator
813ede3 to
b3c1fd7
Compare
Author
|
I updated this PR branch on top of the latest Validation rerun on the rebased branch:
The branch should no longer be in a conflicting state. |
This was referenced May 8, 2026
b3c1fd7 to
1615c02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawntool's optionalagent_idthrough to sub-turn executionspawnsub-turns as critical so they can continue after the parent turn finishesProblem
The
spawntool already exposes anagent_idparameter and validates it with the configured allowlist, but the actual sub-turn execution ignored the target agent. The child turn was created from the parent/default agent instead, sospawn(agent_id: "...")could acknowledge the target while still running with the wrong agent configuration.That breaks multi-agent setups where agents intentionally have different tools, workspaces, skills, or models.
Fix
This PR adds
AgentIDto the tool/agent sub-turn config path and resolves the target agent insidespawnSubTurn. If noagent_idis provided, behavior remains unchanged: the child turn uses the parent agent and falls back to the default agent.Validation