fix(channels): make tool feedback edit throttle configurable#2789
Open
bogdanovich wants to merge 2 commits intosipeed:mainfrom
Open
fix(channels): make tool feedback edit throttle configurable#2789bogdanovich wants to merge 2 commits intosipeed:mainfrom
bogdanovich wants to merge 2 commits intosipeed:mainfrom
Conversation
This was referenced May 7, 2026
743e4d6 to
c8611f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make editable tool feedback progress throttling configurable instead of hard-coding a new behavior into all channels.
This adds two
agents.defaults.tool_feedbacksettings:animation_interval_secscontrols the progress animation edit interval. It defaults to3, preserving the existing animation cadence.edit_min_interval_secondscontrols the minimum interval between edits of the same tracked progress message. It defaults to0, preserving legacy behavior with no edit throttle.When
edit_min_interval_secondsis enabled, the animator coalesces rapid updates into its tracked state instead of immediately editing the same message again. It also honors Telegram-styleretry after N/ 429 rate-limit errors by temporarily pausing edits for that tracked message.Why
Some chat platforms share message send/edit limits. Long-running tool feedback, especially with concurrent turns or subagents, can otherwise hit platform rate limits and delay or orphan progress cleanup. Making the throttle configurable lets deployments opt in without changing default behavior for existing channels.
Backward compatibility
Defaults preserve existing behavior:
{ "agents": { "defaults": { "tool_feedback": { "animation_interval_secs": 3, "edit_min_interval_seconds": 0 } } } }Testing
go test ./pkg/channelsgo test ./pkg/channels/telegram ./pkg/channels/discord ./pkg/channels/picogo test ./pkg/channels/feishugo test ./pkg/configgo test ./pkg/agentmake buildNote: direct
go test ./pkg/channels/matrixcannot run in this environment because the systemolm/olm.hheader is unavailable, butmake buildsucceeds.