fix(cron): suppress feedback for scheduled turns#2777
Open
bogdanovich wants to merge 1 commit intosipeed:mainfrom
Open
fix(cron): suppress feedback for scheduled turns#2777bogdanovich wants to merge 1 commit intosipeed:mainfrom
bogdanovich wants to merge 1 commit intosipeed:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scheduled cron agent jobs currently run through the same foreground message path as user messages. When
tool_feedbackis enabled, background cron jobs can emit transient progress/tool messages such asWorking...into the chat even though there is no active user turn.This PR adds a scheduled agent execution path for cron jobs that mirrors the existing heartbeat behavior:
JobExecutorimplementations by using an optional scheduled executor interfaceTests
go test ./pkg/tools -run 'CronTool_ExecuteJob'go test ./pkg/agent -run 'ProcessScheduled|ProcessHeartbeat|ToolFeedback'git diff --check HEAD~1..HEAD