Skip to content

fix: boolean handler must not coerce None or empty-string to False #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afkerhousse wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: boolean handler must not coerce None or empty-string to False #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions singer/transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,12 @@ def _transform(self, data, typ, schema, path):
return False, None

elif typ == "boolean":
# None and "" must fall through to the null handler; bool(None)
# and bool("") both return False without raising, which would
# silently coerce null values to false for ["null", "boolean"] schemas.
if data is None or data == "":
return False, None

if isinstance(data, str) and data.lower() == "false":
return True, False

Expand Down