Skip to content

Store API data in local storage instead of sync storage. #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FozzieHi wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Store API data in local storage instead of sync storage. #122

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4740f36
Store API data in local storage instead of sync storage.
FozzieHi Feb 13, 2022
b1a7a53
Formatting.
FozzieHi Feb 13, 2022
a5bf20c
Set default type to local.
FozzieHi Feb 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/background/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,7 @@ browser.commands.onCommand.addListener(async (command) => {
}
});

SLStorage.convertFromSyncToLocal(SLStorage.SETTINGS.API_URL);
SLStorage.convertFromSyncToLocal(SLStorage.SETTINGS.API_KEY);
APIService.initService();
Onboarding.initService();
29 changes: 25 additions & 4 deletions src/popup/SLStorage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ class SLStorage {
SL_BUTTON_POSITION: "SLButtonPosition",
};

static TYPES = {
apiUrl: "local",
apiKey: "local",
notAskingRate: "sync",
showSLButton: "sync",
SLButtonPosition: "sync",
};

static DEFAULT_SETTINGS = {
[SLStorage.SETTINGS.API_URL]: devConfig
? devConfig.DEFAULT_API_URL
Expand All @@ -23,11 +31,13 @@ class SLStorage {
};

static set(key, value) {
return browser.storage.sync.set({ [key]: value });
const type = this.TYPES[key];
return browser.storage[type].set({ [key]: value });
}

static async get(key) {
const data = await browser.storage.sync.get(key);
const type = this.TYPES[key];
const data = await browser.storage[type].get(key);

if (data[key] === undefined || data[key] === null) {
return SLStorage.DEFAULT_SETTINGS[key] || "";
Expand All @@ -37,10 +47,12 @@ class SLStorage {
}

static remove(key) {
return browser.storage.sync.remove(key);
const type = this.TYPES[key];
return browser.storage[type].remove(key);
}

static clear() {
static async clear() {
await browser.storage.local.clear();
return browser.storage.sync.clear();
}

Expand All @@ -51,6 +63,15 @@ class SLStorage {
static getTemporary(key) {
return TEMP[key];
}

static async convertFromSyncToLocal(key) {
const data = await browser.storage.sync.get(key);
if (data[key]) {
await browser.storage.local
.set({ [key]: data[key] })
.then((_) => browser.storage.sync.remove(key));
}
}
}

export default SLStorage;