Open
Conversation
BenediktO
force-pushed
the
improve_jtag_speed
branch
from
2b3177b to
84e4f48
Compare
Krakonos
approved these changes
Nov 30, 2025
Krakonos
left a comment
Krakonos
left a comment
There was a problem hiding this comment.
The code decoding code cleanup is worth it and while I don't have any JTAG samples long enough to see the improvement, I don't see any degradation either. @BenediktO If possible, could you contribute a sample that takes a bit of time to decode for a benchmark?
@abraxa I recommend this PR for merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR improves the speed of the JTAG decoding.
It is accomplished by removing an if-elsif-chain and refactoring its logic into a dictionary. This gave roughly 30% speedup when using sigrok-cli on a 20s sample I captured.
In addition I decode the bits only once and use it to generate the binary and hex representation.
All tests still pass.