Rename rgb_led_ws281x rgb_led_clockless, add lighting tag, and add options for it to decode a wider range of rgb strips#119
Open
lsellens wants to merge 3 commits intosigrokproject:masterfrom
Open
Conversation
add Lighting tag to it and rgb_led_spi
- added a new option to specify the LED type (WS281x or SK6812) to resolves timing issues specific to SK6812 LEDs - added option for is_rgbw so white can be applied to any RGB order(might be a problem if any strips have white as any byte other then the 4th) - moved preprocess options to its own method - fixed handling of the last bit before the reset by extending its annotation and properly managing the reset timing The decoder was tested with both WS2812b and SK6812 LED strips to confirm the accuracy of timing adjustments and bit handling improvements.
…riod. Split 4th byte(white component) into its own annotation with options to display Hex Decimal or Percent. Added option to display first 3 bytes(RGB components) in decimal format. Moved several repetitive tasks to their own methods. Improved the handling of RESET conditions within the decode method, ensuring accurate annotation and timing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revamp of a lot of the code
The decoder was tested with both WS2812b and SK6812 LED strips to confirm the accuracy of timing adjustments and bit handling improvements.