Open
Conversation
without this patch, decode() wouldn't save oldlclk unless lclk is low. Making the rest of the function repeat every sample while lclk is high, instead of on the rising edge.
Author
|
Update, been working with a local copy of this decoder and it seems to have issue after issue. I might update this eventually with an even more stable adjustment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch,
decode()doesn't saveoldlclkunlesslclkis low. Making the rest of the loop repeat every sample thatlclkis high, instead of on the rising edge as is defined by the LPC and PCI standards.