-
Notifications
You must be signed in to change notification settings - Fork 17
fix(ix-chip): deploy PR 2420 changes in scope of IX-3654 #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexkaduk
wants to merge
9
commits into
main
Choose a base branch
from
feature/IX-3654-chip-a11y
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e3e17f3
fix: adjust angular versions IX-3873
alexkaduk a7fb37c
fix: adjust angular versions IX-3873
alexkaduk d21c69f
Update docs/home/installation/angular.md
lzeiml 73802f9
Merge branch 'main' into feature/IX-3873
lzeiml 2e3a3cd
Merge branch 'main' into feature/IX-3873
alexkaduk 10805dd
fix: adjust angular versions IX-3873
alexkaduk fd7867d
fix: deploy PR 2420 changes in scope of IX-3654
alexkaduk 4c2a84a
fix: deploy PR 2420 changes in scope of IX-3654
alexkaduk 61db86c
fix: deploy PR 2420 changes in scope of IX-3654
alexkaduk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| DOCS_BRANCH='main' | ||
| DOCS_BRANCH_TYPE='pull request' | ||
|
|
||
| DOCS_PR_NUMBER='2420' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,12 +13,14 @@ import TabItem from '@theme/TabItem'; | |
|
|
||
| ### Peer dependencies | ||
|
|
||
| Both `@angular/core` and `@angular/forms` are peer dependencies which means they must be installed before iX. | ||
| Both `@angular/core` and `@angular/forms` are peer dependencies that you must install before iX. | ||
|
|
||
| For the exact version requirements, see the [peerDependencies in package.json](https://github.com/siemens/ix/blob/main/packages/angular/package.json) (search for `peerDependencies` in that file). | ||
|
|
||
| ```json | ||
| "peerDependencies": { | ||
| "@angular/core": ">=18.2.13", | ||
| "@angular/forms": ">=18.2.13", | ||
| "@angular/core": ">=20", | ||
| "@angular/forms": ">=20", | ||
| } | ||
| ``` | ||
|
Comment on lines
20
to
25
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This code block showing References
|
||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoding the pull request number
DOCS_PR_NUMBERmakes this configuration specific to PR #2420 and not reusable for other pull requests. This could lead to issues in CI/CD pipelines for other PRs if this file is used. It's recommended to source this value from an environment variable provided by the CI system (e.g.,process.env.GITHUB_PULL_REQUEST_NUMBERon GitHub Actions).