Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request disables global test isolation in the Vitest configuration and updates several test files to ensure proper cleanup by adding vi.restoreAllMocks() and vi.useRealTimers() in afterEach blocks. It also refactors assertions in the datatable tests to use toContainEqual with expect.objectContaining and adds manual timer advancement in focus-related tests. Feedback was provided to ensure vi.restoreAllMocks() is consistently applied in test files where mocks are used to prevent cross-test leakage.
spike-rabbit
force-pushed
the
test/element-ng/disable-isolation
branch
2 times, most recently
from
b1b25c9 to
5cc61e4
Compare
This is the default by vitest and improves performance significantly. A lot of those fallbacks for `vi.useRealTimers()` were introduced, to increase general stability.
spike-rabbit
force-pushed
the
test/element-ng/disable-isolation
branch
from
5cc61e4 to
beb31b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the default by vitest and improves performance significantly.