Skip to content

fix(typography): align code and pre tags with UX#1775

Open
spike-rabbit wants to merge 1 commit intomainfrom
fix/markdown/align-with-ux
Open

fix(typography): align code and pre tags with UX#1775
spike-rabbit wants to merge 1 commit intomainfrom
fix/markdown/align-with-ux

Conversation

@spike-rabbit
Copy link
Copy Markdown
Member

@spike-rabbit spike-rabbit commented Mar 30, 2026

Previously forgotten, code and pre tags now have proper UX aligned styling.


Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

@spike-rabbit spike-rabbit requested review from a team as code owners March 30, 2026 16:35
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the global styling for code-related elements by introducing new variables and aligning them with the design system's semantic tokens and typography. Key changes include renaming font family variables, updating font sizes and line heights, and adding borders to preformatted blocks. Redundant style overrides were removed from the reboot and markdown stylesheets, which led to updated visual snapshots for various components. Feedback was provided to further align the code styles within the markdown component to ensure consistency with the new global variables.

@spike-rabbit spike-rabbit force-pushed the fix/markdown/align-with-ux branch 2 times, most recently from 6b2e219 to 8eb6369 Compare March 30, 2026 17:22
@spike-rabbit spike-rabbit requested a review from panch1739 March 30, 2026 17:22
Previously forgotten, `code` and `pre` tags now have proper UX aligned styling.
@spike-rabbit spike-rabbit force-pushed the fix/markdown/align-with-ux branch from 8eb6369 to 28c9a03 Compare March 30, 2026 17:54
Copy link
Copy Markdown
Member

@panch1739 panch1739 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the markdown renderer and it looks good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants