feat(formly): add formly-next entry point with ngx-formly v7 support#1771
feat(formly): add formly-next entry point with ngx-formly v7 support#1771chintankavathia wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request upgrades @ngx-formly to version 7 and introduces SiFormlyNextComponent as the new component for this version, while deprecating the existing SiFormlyComponent and SiFormlyModule. The application configuration and examples have been updated to use the new component and the provideFormlyCore provider. Feedback includes a request to apply ChangeDetectionStrategy.OnPush to the new component per the style guide and to remove a redundant commented-out import in the app configuration.
56f7066 to
71acaa1
Compare
spike-rabbit
left a comment
There was a problem hiding this comment.
I am a little divided here:
Can we wait until v50 an then just fully update to formly@7?
Or this there a way, where we can still have the same 6 and 7 with the exact same entry point and code?
Introduce `@siemens/element-ng/formly-next` as a separate secondary entry
point supporting `@ngx-formly/core` v7. This enables standalone component
usage without NgModules, improved tree-shaking through provider-based
configuration, and alignment with modern Angular patterns.
The existing `@siemens/element-ng/formly` entry point remains v6-compatible.
Before (v6 — `@siemens/element-ng/formly`):
```ts
import { SiFormlyModule } from '@siemens/element-ng/formly';
@NgModule({
imports: [SiFormlyModule.forRoot()]
})
export class AppModule {}
```
After (v7 — `@siemens/element-ng/formly-next`):
```ts
import { SiFormlyNextComponent } from '@siemens/element-ng/formly-next';
@component({
imports: [SiFormlyNextComponent]
})
export class MyComponent {}
```
71acaa1 to
16d7a7e
Compare
Introduce
@siemens/element-ng/formly-nextas a separate secondary entry point supporting@ngx-formly/corev7. This enables standalone component usage without NgModules, improved tree-shaking through provider-based configuration, and alignment with modern Angular patterns.The existing
@siemens/element-ng/formlyentry point remains v6-compatible. BothSiFormlyComponentandSiFormlyModuleare marked as deprecated with guidance to migrate toSiFormlyNextComponentwhen upgrading to v7.Before (v6 —
@siemens/element-ng/formly):After (v7 —
@siemens/element-ng/formly-next):Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: