Skip to content

fix(charts): add missing echarts imports#1770

Open
akashsonune wants to merge 1 commit intomainfrom
fix/import-missing-echarts-components
Open

fix(charts): add missing echarts imports#1770
akashsonune wants to merge 1 commit intomainfrom
fix/import-missing-echarts-components

Conversation

@akashsonune
Copy link
Copy Markdown
Member

@akashsonune akashsonune commented Mar 27, 2026 •
edited by github-actions bot
Loading

@akashsonune akashsonune requested review from a team as code owners March 27, 2026 11:01
gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds CustomChart, PolarComponent, and SingleAxisComponent to the si-chart component. The removal of DatasetComponent from the ECharts configuration is a breaking change for consumers using the dataset feature. Re-add DatasetComponent to maintain backward compatibility and support all core ECharts features.

spliffone
spliffone reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@spliffone spliffone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a VRT that we don't accidentally break the behaviour again?

@akashsonune akashsonune force-pushed the fix/import-missing-echarts-components branch from 606dea2 to 0bcdf7f Compare March 27, 2026 11:13
@akashsonune
Copy link
Copy Markdown
Member Author

akashsonune commented Mar 27, 2026

Can you provide a VRT that we don't accidentally break the behaviour again?

@spliffone These are really special type of charts components, and we just support them for generic si-charts
I am not really sure if we should provide examples for these but rather keep our chart offerings simple.

Idea here was to just provide backward compatibility in case someone is already using these charts,
/cc @dr-itz

@akashsonune akashsonune requested a review from spliffone March 27, 2026 11:31
@akashsonune akashsonune changed the title fix(charts): import missing echarts imports fix(charts): add missing echarts imports Mar 27, 2026
@spliffone spliffone enabled auto-merge March 31, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spliffone spliffone Awaiting requested review from spliffone

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@dr-itz dr-itz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DatasetComponent not registered, causing dataset configuration to be ignored in ECharts 6

3 participants

@akashsonune @spliffone @dr-itz