Skip to content

feat(forms): align input colors with guidelines#1732

Open
robertwilde wants to merge 1 commit intomainfrom
feat/forms/colors
Open

feat(forms): align input colors with guidelines#1732
robertwilde wants to merge 1 commit intomainfrom
feat/forms/colors

Conversation

@robertwilde
Copy link
Copy Markdown
Collaborator

@robertwilde robertwilde commented Mar 24, 2026

Closes #1608
Closes #1609
Updated colors for checkbox, radio, switch and text input in alignment with iX.


Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the styling of form elements, including checkboxes, radio buttons, input fields, and switches, to align with new semantic tokens. This involves changes to background colors, border colors, and text colors for various states like hover, active, checked, and disabled. The review highlights an invalid CSS property border: 1; in the switch component, which should be corrected to border: 1px solid .... Additionally, it points out a visibility issue in the checked radio button's active state where the ::after element's background color matches the primary active background, making it invisible, and suggests using $element-action-primary-text for consistency.

@robertwilde robertwilde force-pushed the feat/forms/colors branch 4 times, most recently from a9e6730 to cc31868 Compare March 26, 2026 10:47
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

⬇️ Download VRTs

@robertwilde robertwilde force-pushed the feat/forms/colors branch 5 times, most recently from c5a4065 to 3b13337 Compare March 27, 2026 13:13
@robertwilde robertwilde marked this pull request as ready for review March 27, 2026 14:43
@robertwilde robertwilde requested review from a team as code owners March 27, 2026 14:43
@robertwilde
Copy link
Copy Markdown
Collaborator Author

e2e tests are failing randomly on this one

Copy link
Copy Markdown
Member

@panch1739 panch1739 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertwilde Thank you so much! I found some small alignment problems

Switch

The check knob seems to have shifted one pixel. The distance between the check knob and the border should be 4px:

Image

In the disabled state, for the check version, the outline from the uncheck version remains visible:

Image

Radio

The hover effect seems to be applying only to the border:

Image

Text inputs

They seem to be using base-hover, but they should use base-input:

Image

We briefly discussed this token on teams, but maybe is not clear for me..is it not accessible in the code the base-input(experimental) token?

Thank youuu

@robertwilde robertwilde force-pushed the feat/forms/colors branch 3 times, most recently from daac4fd to 3391469 Compare March 30, 2026 15:06
@robertwilde
Copy link
Copy Markdown
Collaborator Author

robertwilde commented Mar 30, 2026

@robertwilde Thank you so much! I found some small alignment problems

Switch

The check knob seems to have shifted one pixel. The distance between the check knob and the border should be 4px:

Image In the disabled state, for the check version, the outline from the uncheck version remains visible: Image **Radio**

The hover effect seems to be applying only to the border:

Image **Text inputs**

They seem to be using base-hover, but they should use base-input:

Image We briefly discussed this token on teams, but maybe is not clear for me..is it not accessible in the code the base-input(experimental) token?

Thank youuu

@panch1739 @spike-rabbit I integrated your feedback, updated everything and - from my side - it could be merged.

Copy link
Copy Markdown
Member

@panch1739 panch1739 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertwilde now it looks good! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update colors for input controls Update form input tokens

3 participants