Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/kind-starter-template-newsletter.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"vue-starter-template": patch
---

Remove the extra newsletter status call after subscribing on the account overview now that `useNewsletter` syncs from the API response.
5 changes: 5 additions & 0 deletions .changeset/sharp-eagles-sync.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@shopware/composables": patch
---

Update `useNewsletter` so `newsletterStatus` is set from the subscribe API response, keeping `isNewsletterSubscriber` in sync without an extra status request.
5 changes: 5 additions & 0 deletions .changeset/swift-demo-store-newsletter.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"vue-demo-store": patch
---

Remove redundant newsletter status refresh on the account overview now that `useNewsletter` updates state after subscribe.
1 change: 1 addition & 0 deletions packages/composables/src/useNewsletter/useNewsletter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export function useNewsletter(): UseNewsletterReturn {
},
},
);
newsletterStatus.value = result.data.status;
return result.data;
Comment on lines +81 to 82
}

Expand Down
3 changes: 0 additions & 3 deletions templates/vue-demo-store/app/pages/account/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,6 @@ async function updateNewsletterStatus() {
}
}
} finally {
await getNewsletterStatus();

newsletter.value = isNewsletterSubscriber.value;
newsletterDisabled.value = false;
}
Comment on lines 63 to 65
}
Expand Down
2 changes: 0 additions & 2 deletions templates/vue-starter-template/app/pages/account/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ async function handleNewsletterChange() {
email: user.value?.email || "",
option: SUBSCRIBE_KEY,
});
// Wait to avoid UI flickering
await getNewsletterStatus();
pushSuccess(t("account.overview.newsletter.messages.subscribed"));
} else {
await newsletterUnsubscribe(user.value?.email || "");
Expand Down
Loading