Open
Conversation
ckkz-it
commented
Apr 15, 2026
Comment on lines
-196
to
+197
| del detected['platform'] | ||
| if 'platform' not in res: | ||
| del detected['platform'] |
Author
There was a problem hiding this comment.
the platform wasn't tested before in tests, I don't know was it intentional or not, but that's the only way I can test the typo fix - let me know if you want me to keep only typo fix, without test updates
Author
|
I wanted to use it as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove leading space in ChromeOS platform string and update test expectations