fix(tab-group): ensure indicator is visible with 1px track-width#2540
Open
Br1an67 wants to merge 1 commit intoshoelace-style:nextfrom
Open
fix(tab-group): ensure indicator is visible with 1px track-width#2540Br1an67 wants to merge 1 commit intoshoelace-style:nextfrom
Br1an67 wants to merge 1 commit intoshoelace-style:nextfrom
Conversation
The indicator was invisible when --track-width was set to 1px because box-sizing: border-box (inherited from component styles) caused the border to be drawn inside the element's 0-height content area. Adding box-sizing: content-box to the indicator ensures the border extends outside the content area and remains visible.
|
@Br1an67 is attempting to deploy a commit to the Font Awesome Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Hi, thanks for the PR. Unfortunately, Shoelace is in maintenance mode now that Web Awesome ("Shoelace 3") is available. I believe this might have been fixed upstream already, but if you notice it's still an issue in WA we'll be more than happy to accept a PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2415
Summary
The tab group indicator was invisible when
--track-widthwas set to 1px. This was caused bybox-sizing: border-box(inherited from component styles) which drew the border inside the indicator element's 0-height content area, making it effectively hidden.Changes
box-sizing: content-boxto.tab-group__indicatorinsrc/components/tab-group/tab-group.styles.tsto ensure the border extends outside the content area and remains visible regardless of track-width value.Testing
Verified that the fix allows the indicator border to render properly when
--track-widthis set to 1px (or any value), as the border now extends beyond the element's content box rather than being clipped inside it.git diff --stat HEAD~1 src/components/tab-group/tab-group.styles.ts | 1 + 1 file changed, 1 insertion(+)