Skip to content

Use data attribute to determine safe triangle position #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ggPeti wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Use data attribute to determine safe triangle position #2484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/menu-item/submenu-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,16 +195,16 @@
private handlePopupReposition = () => {
const submenuSlot: HTMLSlotElement | null = this.host.renderRoot.querySelector("slot[name='submenu']");
const menu = submenuSlot?.assignedElements({ flatten: true }).filter(el => el.localName === 'sl-menu')[0];
const isRtl = getComputedStyle(this.host).direction === 'rtl';
const isOnLeft = this.popupRef.value?.attributes?.['data-current-placement']?.startsWith('left');

Check failure on line 198 in src/components/menu-item/submenu-controller.ts

View workflow job for this annotation

GitHub Actions / build 

Unsafe member access .startsWith on an `any` value

Check failure on line 198 in src/components/menu-item/submenu-controller.ts

View workflow job for this annotation

GitHub Actions / build 

Unsafe call of an `any` typed value

Check failure on line 198 in src/components/menu-item/submenu-controller.ts

View workflow job for this annotation

GitHub Actions / build 

Unsafe assignment of an `any` value
if (!menu) {
return;
}

const { left, top, width, height } = menu.getBoundingClientRect();

this.host.style.setProperty('--safe-triangle-submenu-start-x', `${isRtl ? left + width : left}px`);
this.host.style.setProperty('--safe-triangle-submenu-start-x', `${isOnLeft ? left + width : left}px`);
this.host.style.setProperty('--safe-triangle-submenu-start-y', `${top}px`);
this.host.style.setProperty('--safe-triangle-submenu-end-x', `${isRtl ? left + width : left}px`);
this.host.style.setProperty('--safe-triangle-submenu-end-x', `${isOnLeft ? left + width : left}px`);
this.host.style.setProperty('--safe-triangle-submenu-end-y', `${top + height}px`);
};

Expand Down
Loading