Skip to content

dynamically added active tab in angular does not show any panel content #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kirchsuSICKAG wants to merge 1 commit into
base: next
Choose a base branch
from
Open

dynamically added active tab in angular does not show any panel content #2421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions src/components/tab-group/tab-group.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import '../../internal/scrollend-polyfill.js';
import { classMap } from 'lit/directives/class-map.js';
import { eventOptions, property, query, state } from 'lit/decorators.js';
import { eventOptions, property, query, queryAssignedElements, state } from 'lit/decorators.js';
import { html } from 'lit';
import { LocalizeController } from '../../utilities/localize.js';
import { scrollIntoView } from '../../internal/scroll.js';
Expand Down Expand Up @@ -49,11 +49,12 @@ export default class SlTabGroup extends ShoelaceElement {
private activeTab?: SlTab;
private mutationObserver: MutationObserver;
private resizeObserver: ResizeObserver;
private tabs: SlTab[] = [];
private focusableTabs: SlTab[] = [];
private panels: SlTabPanel[] = [];
private readonly localize = new LocalizeController(this);

@queryAssignedElements({ slot: 'nav', selector: 'sl-tab' }) tabs: SlTab[];
@queryAssignedElements({ selector: 'sl-tab-panel' }) panels: SlTabPanel[];

@query('.tab-group') tabGroup: HTMLElement;
@query('.tab-group__body') body: HTMLSlotElement;
@query('.tab-group__nav') nav: HTMLElement;
Expand Down Expand Up @@ -167,16 +168,6 @@ export default class SlTabGroup extends ShoelaceElement {
}
}

private getAllTabs() {
const slot = this.shadowRoot!.querySelector<HTMLSlotElement>('slot[name="nav"]')!;

return slot.assignedElements() as SlTab[];
}

private getAllPanels() {
return [...this.body.assignedElements()].filter(el => el.tagName.toLowerCase() === 'sl-tab-panel') as [SlTabPanel];
}

private getActiveTab() {
return this.tabs.find(el => el.active);
}
Expand Down Expand Up @@ -341,8 +332,7 @@ export default class SlTabGroup extends ShoelaceElement {

// We can't used offsetLeft/offsetTop here due to a shadow parent issue where neither can getBoundingClientRect
// because it provides invalid values for animating elements: https://bugs.chromium.org/p/chromium/issues/detail?id=920069
const allTabs = this.getAllTabs();
const precedingTabs = allTabs.slice(0, allTabs.indexOf(currentTab));
const precedingTabs = this.tabs.slice(0, this.tabs.indexOf(currentTab));
const offset = precedingTabs.reduce(
(previous, current) => ({
left: previous.left + current.clientWidth,
Expand All @@ -368,12 +358,9 @@ export default class SlTabGroup extends ShoelaceElement {
}
}

// This stores tabs and panels so we can refer to a cache instead of calling querySelectorAll() multiple times.
private syncTabsAndPanels() {
this.tabs = this.getAllTabs();
this.focusableTabs = this.tabs.filter(el => !el.disabled);

this.panels = this.getAllPanels();
this.syncIndicator();

// After updating, show or hide scroll controls as needed
Expand Down