Open
Conversation
Small storage fix
Remove storage import from file-manager, Change logic in main, Change code style in files, Remove server package, Fix tests
Separate filemanager layer from handlers, Improve filemanager handling in storage
Some code refactor
avhitrov
requested changes
May 31, 2024
Collaborator
avhitrov
left a comment
avhitrov
left a comment
There was a problem hiding this comment.
- Необходимо изменить источник контекста для БД-функций.
- Следует унифицировать интерфейса стораджей
- Предлагаю скомпилировать с ключом
-raceи побомбить сервер на предмет гонок, взяв скрипт отсюда: https://github.com/avhitrov/shorterbomber
| return &DataBase{DB: db}, err | ||
| } | ||
|
|
||
| func (db *DataBase) AddRecord(short, url string) error { |
Collaborator
There was a problem hiding this comment.
Suggested change
| func (db *DataBase) AddRecord(short, url string) error { | |
| func (db *DataBase) AddRecord(ctx context.Context, short, url string) error { |
Контекст здесь и везде в функциях, обрабатывающих пользовательские запросы, необходимо брать из контекста http-запроса (r.Context()), а не из воздyха. Соответственно, это должно отразиться и в интерфейсе.
|
|
||
| var currentStorageType int | ||
|
|
||
| func (s Storage) Add(short, url string) error { |
Collaborator
There was a problem hiding this comment.
Гораздо правильнее будет реализовать единый интерфейс для разных стораджей (in-memory, file, db) и в момент инициализации определять по конфигурации, какой сторадж будет использоваться, инициализировать этот сторадж и скармливать его приемнику интерфейс в сервис или хендлер.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add uniqueness validation for DB and some refactoring