Use the 'request' event instead of calling the first event handler di…#1107
Open
pixcai wants to merge 3 commits intosenchalabs:masterfrom
Open
Use the 'request' event instead of calling the first event handler di…#1107pixcai wants to merge 3 commits intosenchalabs:masterfrom
pixcai wants to merge 3 commits intosenchalabs:masterfrom
Conversation
Contributor
|
It's certainly possible to add. Can you add tests to our test suite for this, please? |
Author
|
Update and add test |
Jonnyboy1982
approved these changes
May 25, 2024
WestPop1
approved these changes
Sep 12, 2025
OICHI56
approved these changes
Sep 16, 2025
|
Shouldn't the readme also be updated, since this is quite a fundamental change to how Connect works? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If only use the first handler, "hello" can be output to the console, however "world" and
res.end('nodejs')will not be invoked, whileemit('request')can. Maybe we should do this?