feat: httpConfig CDN support for retry-settings tests#1188
Merged
MichaelGHSeg merged 2 commits intomasterfrom Mar 27, 2026
Merged
feat: httpConfig CDN support for retry-settings tests#1188MichaelGHSeg merged 2 commits intomasterfrom
MichaelGHSeg merged 2 commits intomasterfrom
Conversation
… flags - Read httpConfig from integrations["Segment.io"] in SegmentDestination.update(), falling back to top-level CDN config via analytics.getHttpConfig() - Add backoffEnabled parameter to classifyError() so that transient errors are classified as permanent when backoffConfig.enabled is false - Also handle rateLimitEnabled + statusCodeOverrides interaction when the relevant config is disabled - Add retry-settings test suite to e2e-config.json Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MichaelGHSeg
changed the title
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
abueide
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httpConfigfromintegrations["Segment.io"]inSegmentDestination.update(), falling back to top-level CDN config viaanalytics.getHttpConfig()backoffEnabledparameter toclassifyError()so transient errors are classified as permanent whenbackoffConfig.enabledisfalse(same for rate limit overrides whenrateLimitEnabledisfalse)retry-settingstest suite andHTTP_CONFIG_SETTINGSenv toe2e-config.jsonTest plan
🤖 Generated with Claude Code